Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

78 - finalize PRD-027 examples #79

Merged
merged 13 commits into from
Apr 9, 2024
Merged

Conversation

EdwinWiseOne
Copy link
Contributor

@EdwinWiseOne EdwinWiseOne commented Apr 8, 2024

Closes #78

Move the Core examples down, increase the version numbers, clean stuff up generally, and rework the Tools and github workflow for tetsing.

This was branched from the PRD 027 integration branch, but is targeting main.

@EdwinWiseOne
Copy link
Contributor Author

I can build and publish all of the examples except for React, which hangs on the "npm run build" step with:

> parcel build --dist-dir ./dist

Note that we can build inside of the github workflow for testing.

@andrewcollette
Copy link
Contributor

Hmmm... would be good to figure out the build failure as it may affect others. I googled briefly for parcel problems and found this, among others: parcel-bundler/parcel#7585

That ticket suggests disabling optimization as a possible workaround (if that is indeed the issue you're having).

@EdwinWiseOne
Copy link
Contributor Author

Fixed the react build issue!

Copy link
Contributor

@andrewcollette andrewcollette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There is just one change; based on past discussions with Amir we are going to remove the Externally-Hosted example. We no longer offer the "built-in" auth that example demonstrates, and the current state of the art for consulting projects uses a different approach. Once that folder is removed it's OK to merge.

@EdwinWiseOne EdwinWiseOne merged commit b5d3821 into main Apr 9, 2024
5 checks passed
@EdwinWiseOne EdwinWiseOne deleted the 78-finalize_prd27_examples branch April 9, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finalize PRD 027 example changes
2 participants