Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StackedBarPlot prototype -- feedback wanted #24

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tvaught
Copy link
Contributor

@tvaught tvaught commented Sep 13, 2011

This is a first-cut at a StackedBarPlot renderer, with an example. It still needs some features, but I wanted to get it out there to see if I'm barking up the right tree in how to add it. (I really need to do a code review, if anyone's game). There's an example included, and it works for my purposes. However, I'd like to see the features fleshed out if anyone wants to help tackle this with me.

Best,

Travis

 - axis labels from text lists
 - screen-space bar widths
 - better color designation (currently a list of colors, or ["auto"])
 - I'm sure there's a lot more...
@nmichaud
Copy link

nmichaud commented May 7, 2012

Hi Travis, not sure if you are still interested in merging this, but it looks good to me. Can you bring it up to date with current chaco master?

@tvaught
Copy link
Contributor Author

tvaught commented May 7, 2012

I'll be able to look it over next week. I'm interested in getting it in, but remember that there was still a bit of code smell that I wanted to think about.

Best,

Travis

On May 7, 2012, at 1:09 PM, nmichaudreply@reply.github.com wrote:

Hi Travis, not sure if you are still interested in merging this, but it looks good to me. Can you bring it up to date with current chaco master?


Reply to this email directly or view it on GitHub:
#24 (comment)

@jonathanrocher
Copy link
Collaborator

@tvaught I just merged current master into your branch (almost no work). If you have time and interest, please update your PR, also adding one or more unit tests. If you don't, I made a new branch on the Enthought chaco repository:
#152
so that others can more easily pick it up and bring it into Chaco.

Let me know what your intentions are. Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants