New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape values when necessary #1

Open

nabertrand wants to merge 1 commit into enterprisemodules:master from umnmsi:escape_values

nabertrand commented Aug 11, 2020

This PR allows values containing single quotes to be escaped correctly. Prior to this change, given an example manifest

class test {
  file { '/test_file':
    content => "This isn't escaped",
  }
}

dump_catalog wouldn't escape the single quote, producing an invalid code snippet:

it { is_expected.to contain_file('/test_file')
  .with('path'    => '/test_file')
  .with('content' => 'This isn't escaped')
}

With this change, only values that need escaping are escaped, leaving single quotes in other cases:

it { is_expected.to contain_file('/test_file')
  .with('path'    => '/test_file')
  .with('content' => "This isn't escaped")
}


          Escape values when necessary

aed162d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment