Moving away from Integer | Nothing to Rows_To_Read for limiting number of rows.
#9925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done `Table`, `Column`, `DB_Table` and `DB_Column`.
Move some of the functionality into the `Rows_To_Read` type.
jdunkerley
force-pushed
the
wip/jd/read-redesign
branch
from
6a6e981
to
2521426
Compare
jdunkerley
added
the
CI: No changelog needed
jdunkerley
requested review from
radeusgd,
GregoryTravis and
AdRiley
as code owners
| _ -> input | ||
|
|
||
| ## PRIVATE | ||
| Rows_To_Read.from (that:Nothing) = |
There was a problem hiding this comment.
Are these here only to handle existing code that uses the old interface?
There was a problem hiding this comment.
Yep exactly. Any old limits will then be ok. Though not if the warning flag was set.
GregoryTravis
approved these changes
May 13, 2024
radeusgd
reviewed
May 14, 2024
distribution/lib/Standard/Table/0.0.0-dev/src/Rows_To_Read.enso
Outdated
Show resolved
Hide resolved
Co-authored-by: Radosław Waśko <radoslaw.wasko@enso.org>
radeusgd
reviewed
May 14, 2024
Comment on lines
-2147
to
+2146
| read self (max_rows : Nothing | Integer = Nothing) (warn_if_more_rows:Boolean = True) = | ||
| @max_rows Rows_To_Read.default_widget | ||
| read : Rows_To_Read -> Column | ||
| read self (max_rows : Rows_To_Read = ..All_Rows) = |
There was a problem hiding this comment.
This ..All_Rows looks so much clearer than Nothing. I'm really happy with our switching towards more meaningful arguments. And with autoscoping it is still quite terse :)
radeusgd
reviewed
May 14, 2024
Comment on lines
+39
to
+44
| ## PRIVATE | ||
| attach_warning self input:Table -> Table = case self of | ||
| Rows_To_Read.First_With_Warning rows -> if input.row_count <= rows then input else | ||
| Problem_Behavior.Report_Warning.attach_problem_after (input.take (First rows)) <| | ||
| Not_All_Rows_Downloaded.Warning rows | ||
| _ -> input |
There was a problem hiding this comment.
Nice that this is now in a single place, makes the usages much clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Rows_To_Readtype with conversions fromNothingand integers.readonTable,Column,DB_TableandDB_Column.Delimited_Format.Delimitedto useRows_To_Readforrow_limit.Excel_Format.SheetandExcel_Format.Rangeto useRows_To_Readforrow_limit.Excel_Workbook.readto useRows_To_Read.Connection.read(in all connection types) to useRows_To_Read.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.