New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search bar for settings #9887
Open
somebody1234
wants to merge
21
commits into
develop
Choose a base branch
from
wip/sb/search-settings
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Search bar for settings #9887
+2,037
−1,699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somebody1234
added
CI: No changelog needed
Do not require a changelog entry for this PR.
x-new-feature
Type: new feature request
g-dashboard
labels
May 8, 2024
somebody1234
requested review from
PabloBuchu,
indiv0 and
MrFlashAccount
as code owners
May 8, 2024 08:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: No changelog needed
Do not require a changelog entry for this PR.
g-dashboard
x-new-feature
Type: new feature request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
UX changes required for this PR:
MembersSettingsSection
to usereact-query
to avoid loading the members list every time a user types into the search barIncidental changes added to make this PR simpler:
Dashboard
and back down toTopBar
Important Notes
Screencast
Note: The end of this recording contains a bug where the "user account" section was not being matched. This bug has since been fixed.
settings-search-2.mp4
Code Review tips
settingsData.ts
contains the settings converted to JS objectsSettings.tsx
contains the new filtering logicSettings/Settings{Tab,Section,Entry,InputEntry,CustomEntry}
contains the components responsible for rendering the new JS objectsTesting instructions
SettingsEntryType.custom
insettingsData
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.