Duplicate and restore project #9816
Conversation
somebody1234
added
CI: No changelog needed
somebody1234
requested review from
PabloBuchu,
indiv0 and
MrFlashAccount
as code owners
|
@somebody1234 can you fix the conflicts? I will QA this later today and would be great to merge |
| backend={backend} | ||
| latestVersion={latestVersion} | ||
| dispatchAssetListEvent={dispatchAssetListEvent} | ||
| doRestore={() => { | ||
| restoreMutation.mutate({ |
There was a problem hiding this comment.
can we use mutateAsync here? If we pass a function that returns a promise to a button, button will automatically set loading state and remove it once promise resolves
| await versionsQuery.refetch() | ||
| }, | ||
| onError: (error: unknown) => { | ||
| toastAndLog('restoreProjectError', error, item.item.title) |
There was a problem hiding this comment.
Not sure it's a good idea to toast the error, because it will frustrate users - errors happen, but the user can't do anything with the error. Maybe we can show additional actions in Toast? Or maybe display the error inline?
There was a problem hiding this comment.
i don't know about additional actions in toast tbh. inline sounds fine but not sure what's the best way to send the error info back to the button that was responsible for the error
| backend={backend} | ||
| latestVersion={latestVersion} | ||
| dispatchAssetListEvent={dispatchAssetListEvent} |
There was a problem hiding this comment.
Also I think it worth to add "restore" and "duplicate" button right in "Compare" dialog , either in top bar above the editor or in the footer below.
Pull Request Description
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If GUI codebase was changed, the GUI was tested when built using./run ide build.