WIP: Initial Bazel integration #9777
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertp
added
the
CI: No changelog needed
Using latest JDK (after proper GraalVM integration) broke compilation of Scala projects due to a problem with SecurityManager in `scala_rules`. Workaround it by having custom toolchain. Added example BUILD for mixed Scala/Java project with a small number of dependencies.
Akirathan
reviewed
Apr 29, 2024
| ## @vaticle_bazel_distribution seems to rely on | ||
| ## as encountered various issues, including a blocker of | ||
| ## https://github.com/bazelbuild/rules_kotlin/issues/1072. | ||
| rules_kotlin_version = "1.9.0" |
There was a problem hiding this comment.
Dependency of bazel-distribution unfortunately.
Akirathan
reviewed
Apr 29, 2024
| @@ -80,6 +83,10 @@ maven.install( | |||
| "org.apache.commons:commons-lang3:%s" % commons_lang_version, | |||
| "junit:junit:%s" % junit_version, | |||
| "org.hamcrest:hamcrest-all:%s" % hamcrest_version, | |||
|
|
|||
| ## bazel-distribution dependencies | |||
| "info.picocli:picocli:%s" % picocli_version, | |||
There was a problem hiding this comment.
Why do we need picocli? What does bazel-distribution dependencies mean?
There was a problem hiding this comment.
As the comment says, it is a dependency of bazel-distribution rules which are used for generating pom.xml.
This doesn't mean that this dependency is added to any of subprojects. But it has to be listed for the rules so that the dependency (and its version) is discoverable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.