Initial Support for KunaiGC as device #864
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emukidid
reviewed
Apr 15, 2024
| return bytes_read; | ||
| } | ||
|
|
||
| // Assumes a single call to write a file. |
There was a problem hiding this comment.
This comment isn't true because this device isn't considered for bulk file operations here:
swiss-gc/cube/swiss/source/swiss.c
Line 1723 in 6a06ad9
@Extrems we should probably add a "Bulk read/write" attribute to the DEVICEHANDLER_INTERFACE?
There was a problem hiding this comment.
Woops - this slipped. The comment is irrelevant, I probably need to remove it. I basically copied Qoob Device, so its probably a left over.
In fact every file can be written in chunks, as I'm first seeking to the proper position within the file and then writing it. This however may have some performance impacts...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support to browse and use KunaiGC as a config device.
It makes use of the EXI API of libogc2.
Fixes on TIF image may be required.