Update Getting Started installation instructions to make PATH setting clearer for less experienced developers #21661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update downloads.rst
sbc100
reviewed
Apr 1, 2024
| @@ -50,7 +50,12 @@ GitHub and set them as :term:`active <Active Tool/SDK>`: | |||
| ./emsdk activate latest | |||
|
|
|||
| # Activate PATH and other environment variables in the current terminal | |||
| source ./emsdk_env.sh | |||
| source /path/to/emsdk/emsdk_env.sh | |||
There was a problem hiding this comment.
The command just above also uses the ./emsdk syntax.. should we change that too?
| source ./emsdk_env.sh | ||
| source /path/to/emsdk/emsdk_env.sh | ||
|
|
||
| # Verify PATH. This command should return the full path to your emsdk directory |
There was a problem hiding this comment.
"This command should print the full path the emcc compiler withing your emsdk directory"
| # Verify PATH. This command should return the full path to your emsdk directory | ||
| which emcc | ||
|
|
||
| .. note:: If you're struggling to get the ``emcc`` command working, add ``export PATH="/path/to/emsdk/upstream/emscripten:$PATH"`` to your ``/home/username/.bashrc`` file. |
There was a problem hiding this comment.
emsdk activate prints this information, and there is more than one path than you would need to add.
How about: "If you prefer you can update your PATH environment variable yourself. Th emsdk activate command above will print the pathnames you should add".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.