Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list.first is nil not check #247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

qlw319
Copy link

@qlw319 qlw319 commented Apr 12, 2024

No description provided.

Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@emirpasic
Copy link
Owner

Under which circumstance is the index within the range, but the first element is nil?
The function withinRange should take care of that, no?

!list.withinRange(index) || list.first == nil

@qlw319
Copy link
Author

qlw319 commented Apr 12, 2024 via email

@emirpasic
Copy link
Owner

@qlw319 I still not understand how it came to that state. Is size is bigger than zero, should not the first element exist in that case?

Is it perhaps possible to write a simple test first that causes this issue? That way, we could then understand how it came to be and if we fixed the issue

@qlw319
Copy link
Author

qlw319 commented Apr 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants