Skip to content

Commit

Permalink
fix: add new env var
Browse files Browse the repository at this point in the history
  • Loading branch information
eminetto committed Aug 22, 2023
1 parent 77b0414 commit ad971a7
Show file tree
Hide file tree
Showing 9 changed files with 14 additions and 4 deletions.
1 change: 1 addition & 0 deletions .env
Expand Up @@ -20,6 +20,7 @@ GRAFANA_SERVICE_HOST=grafana
# Jaeger
JAEGER_SERVICE_PORT=16686
JAEGER_SERVICE_HOST=jaeger
JAEGER_TRACEPROVIDER=http://${JAEGER_SERVICE_HOST}:14268/api/traces

# Prometheus
PROMETHEUS_SERVICE_PORT=9090
Expand Down
2 changes: 1 addition & 1 deletion auth/go.mod
Expand Up @@ -4,7 +4,7 @@ go 1.21

require (
github.com/dgrijalva/jwt-go v3.2.0+incompatible
github.com/eminetto/api-o11y v0.0.12
github.com/eminetto/api-o11y v0.0.13
github.com/go-chi/chi/v5 v5.0.8
github.com/go-chi/httplog v0.3.0
github.com/go-chi/telemetry v0.2.0
Expand Down
2 changes: 2 additions & 0 deletions auth/go.sum
Expand Up @@ -63,6 +63,8 @@ github.com/eminetto/api-o11y v0.0.11 h1:PbFfGp1Cy7QaR55OBsTE1kovkJw+CT7ZBPeICfiP
github.com/eminetto/api-o11y v0.0.11/go.mod h1:BVyINe/YXuOod6cx9t46GBxnZ5ugi+oGHC59sMThk7Y=
github.com/eminetto/api-o11y v0.0.12 h1:Ek/ycnazLv66Qlj8/LoeDeNG1/ljXwq+DhjMcHXOzG4=
github.com/eminetto/api-o11y v0.0.12/go.mod h1:BVyINe/YXuOod6cx9t46GBxnZ5ugi+oGHC59sMThk7Y=
github.com/eminetto/api-o11y v0.0.13 h1:ueo421MfT+0H5xrXyqXHz6zI4h0bR2enTRzorbGa+UM=
github.com/eminetto/api-o11y v0.0.13/go.mod h1:BVyINe/YXuOod6cx9t46GBxnZ5ugi+oGHC59sMThk7Y=
github.com/envoyproxy/go-control-plane v0.9.0/go.mod h1:YTl/9mNaCwkRvm6d1a2C3ymFceY/DCBVvsKhRF0iEA4=
github.com/envoyproxy/go-control-plane v0.9.1-0.20191026205805-5f8ba28d4473/go.mod h1:YTl/9mNaCwkRvm6d1a2C3ymFceY/DCBVvsKhRF0iEA4=
github.com/envoyproxy/go-control-plane v0.9.4/go.mod h1:6rpuAdCZL397s3pYoYcLgu1mIlRU8Am5FuJP05cCM98=
Expand Down
3 changes: 3 additions & 0 deletions docker-compose.yml
Expand Up @@ -61,6 +61,7 @@ services:
DB_PORT: "3306"
PORT: "8081"
OTEL_EXPORTER_OTLP_ENDPOINT: "${OTEL_EXPORTER_OTLP_ENDPOINT}"
JAEGER_TRACEPROVIDER: "${JAEGER_TRACEPROVIDER}"
ports:
- "8081:8081"
container_name: auth
Expand All @@ -81,6 +82,7 @@ services:
PORT: "8082"
AUTH_URL: "http://auth:8081"
OTEL_EXPORTER_OTLP_ENDPOINT: "${OTEL_EXPORTER_OTLP_ENDPOINT}"
JAEGER_TRACEPROVIDER: "${JAEGER_TRACEPROVIDER}"
ports:
- "8082:8082"
container_name: feedbacks
Expand All @@ -101,6 +103,7 @@ services:
PORT: "8083"
AUTH_URL: "http://auth:8081"
OTEL_EXPORTER_OTLP_ENDPOINT: "${OTEL_EXPORTER_OTLP_ENDPOINT}"
JAEGER_TRACEPROVIDER: "${JAEGER_TRACEPROVIDER}"
ports:
- "8083:8083"
container_name: votes
Expand Down
2 changes: 1 addition & 1 deletion feedbacks/go.mod
Expand Up @@ -3,7 +3,7 @@ module github.com/eminetto/api-o11y/feedbacks
go 1.20

require (
github.com/eminetto/api-o11y v0.0.12
github.com/eminetto/api-o11y v0.0.13
github.com/go-chi/chi/v5 v5.0.8
github.com/go-chi/httplog v0.3.0
github.com/go-chi/telemetry v0.2.0
Expand Down
2 changes: 2 additions & 0 deletions feedbacks/go.sum
Expand Up @@ -61,6 +61,8 @@ github.com/eminetto/api-o11y v0.0.11 h1:PbFfGp1Cy7QaR55OBsTE1kovkJw+CT7ZBPeICfiP
github.com/eminetto/api-o11y v0.0.11/go.mod h1:BVyINe/YXuOod6cx9t46GBxnZ5ugi+oGHC59sMThk7Y=
github.com/eminetto/api-o11y v0.0.12 h1:Ek/ycnazLv66Qlj8/LoeDeNG1/ljXwq+DhjMcHXOzG4=
github.com/eminetto/api-o11y v0.0.12/go.mod h1:BVyINe/YXuOod6cx9t46GBxnZ5ugi+oGHC59sMThk7Y=
github.com/eminetto/api-o11y v0.0.13 h1:ueo421MfT+0H5xrXyqXHz6zI4h0bR2enTRzorbGa+UM=
github.com/eminetto/api-o11y v0.0.13/go.mod h1:BVyINe/YXuOod6cx9t46GBxnZ5ugi+oGHC59sMThk7Y=
github.com/envoyproxy/go-control-plane v0.9.0/go.mod h1:YTl/9mNaCwkRvm6d1a2C3ymFceY/DCBVvsKhRF0iEA4=
github.com/envoyproxy/go-control-plane v0.9.1-0.20191026205805-5f8ba28d4473/go.mod h1:YTl/9mNaCwkRvm6d1a2C3ymFceY/DCBVvsKhRF0iEA4=
github.com/envoyproxy/go-control-plane v0.9.4/go.mod h1:6rpuAdCZL397s3pYoYcLgu1mIlRU8Am5FuJP05cCM98=
Expand Down
2 changes: 1 addition & 1 deletion internal/telemetry/jaeger.go
Expand Up @@ -57,7 +57,7 @@ func createJaegerTraceProvider(ctx context.Context, serviceName string) (*sdktra

exp, err := jaeger.New(
jaeger.WithCollectorEndpoint(
jaeger.WithEndpoint(os.Getenv("JAEGER_SERVICE_HOST") + ":" + os.Getenv("JAEGER_SERVICE_PORT")),
jaeger.WithEndpoint(os.Getenv("JAEGER_TRACEPROVIDER")),
),
)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion votes/go.mod
Expand Up @@ -3,7 +3,7 @@ module github.com/eminetto/api-o11y/votes
go 1.20

require (
github.com/eminetto/api-o11y v0.0.12
github.com/eminetto/api-o11y v0.0.13
github.com/go-chi/chi/v5 v5.0.8
github.com/go-chi/httplog v0.3.0
github.com/go-chi/telemetry v0.2.0
Expand Down
2 changes: 2 additions & 0 deletions votes/go.sum
Expand Up @@ -61,6 +61,8 @@ github.com/eminetto/api-o11y v0.0.11 h1:PbFfGp1Cy7QaR55OBsTE1kovkJw+CT7ZBPeICfiP
github.com/eminetto/api-o11y v0.0.11/go.mod h1:BVyINe/YXuOod6cx9t46GBxnZ5ugi+oGHC59sMThk7Y=
github.com/eminetto/api-o11y v0.0.12 h1:Ek/ycnazLv66Qlj8/LoeDeNG1/ljXwq+DhjMcHXOzG4=
github.com/eminetto/api-o11y v0.0.12/go.mod h1:BVyINe/YXuOod6cx9t46GBxnZ5ugi+oGHC59sMThk7Y=
github.com/eminetto/api-o11y v0.0.13 h1:ueo421MfT+0H5xrXyqXHz6zI4h0bR2enTRzorbGa+UM=
github.com/eminetto/api-o11y v0.0.13/go.mod h1:BVyINe/YXuOod6cx9t46GBxnZ5ugi+oGHC59sMThk7Y=
github.com/envoyproxy/go-control-plane v0.9.0/go.mod h1:YTl/9mNaCwkRvm6d1a2C3ymFceY/DCBVvsKhRF0iEA4=
github.com/envoyproxy/go-control-plane v0.9.1-0.20191026205805-5f8ba28d4473/go.mod h1:YTl/9mNaCwkRvm6d1a2C3ymFceY/DCBVvsKhRF0iEA4=
github.com/envoyproxy/go-control-plane v0.9.4/go.mod h1:6rpuAdCZL397s3pYoYcLgu1mIlRU8Am5FuJP05cCM98=
Expand Down

0 comments on commit ad971a7

Please sign in to comment.