R translation #129
Open
R translation #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. Please rename the Tennis file to Tennis1 or similar to indicate it is Tennis1. I understand you made it a package, there are a lot of files, also generated files (Rd/Doxygen). Do we need these files? I believe that makes the exercise more difficult when there are more files. I would remove the comments with documentation and all generated documentation, as other languages do not have that. What do you think? Also license and Latex files... |
|
Please provide the test in the same style as other languages. While combinations work, the coverage / test cases might be different then the list of explicit ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thank you for this kata :)
I took the liberty of translating version 1 into R; it might interest other members of the community.