Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eframe: Add NativeOptions::persistence_path #4423

Merged
merged 4 commits into from May 27, 2024

Conversation

lucasmerlin
Copy link
Contributor

This allows customizing the persistence path in NativeOptions. Previously, persistence wouldn't work with android because directories-next doesn't support android so eframe would just fail to find a place where it could store its config.

@lucasmerlin lucasmerlin force-pushed the customize-persistence-path branch 3 times, most recently from 5d3be5b to ec07b33 Compare April 27, 2024 11:49
@YgorSouza
Copy link
Contributor

I think this also addresses #914.

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should link to NativeOptions::persistence_path from the docs of App::save too

@emilk emilk added the eframe Relates to epi and eframe label May 27, 2024
@emilk emilk changed the title Add eframe option to specify persistence path eframe: Add NativeOptions::persistence_path May 27, 2024
@emilk emilk merged commit 8553e73 into emilk:master May 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eframe Relates to epi and eframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

android persistence feature
3 participants