Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task(compatibility): Enabling compatibility with versions that are pre-ember-test-waiters #13

Merged
merged 4 commits into from
Aug 2, 2019

Conversation

scalvert
Copy link
Collaborator

@scalvert scalvert commented Aug 2, 2019

Allows for compatibility for apps and addons that are pre-@ember/test-helpers 1.6.0, which was the first version that included ember-test-waiters.

Closes #12

@scalvert scalvert requested a review from rwjblue August 2, 2019 16:45
@scalvert
Copy link
Collaborator Author

scalvert commented Aug 2, 2019

It appears CI is failing due to ember-compatibility-helpers expecting @ember/test-helpers to be either a dependency or a devDependency. We intentionally avoided that with this addon, so I'm not sure the best way to address this. Thoughts?

addon/waiter-manager.ts Outdated Show resolved Hide resolved
testem.js Show resolved Hide resolved
@rwjblue rwjblue merged commit 35d49c4 into master Aug 2, 2019
@rwjblue rwjblue deleted the enable-backwards-compat branch August 2, 2019 21:44
@rwjblue rwjblue added the enhancement New feature or request label Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a legacy waiter when @ember/test-helper version is < 1.5.0
2 participants