-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement {{lazy-mount}} component #887
base: master
Are you sure you want to change the base?
Conversation
WIP because needs tests. |
I have a bit more modern code lying around from my migration. I will share it next week. |
discussed this yesterday with @void-mAlex and this is not future proof and won't work under Embroider. We should think about what this would look like under Embroider so we have path forward. |
@SergeAstapov @void-mAlex can we have a meeting to discuss it further? I'd love to release it given it's part of the original RFC and I can help making it work with Embroider + adding tests |
I am sending my changes in #892 with the idea of them being merged into this PR and then this will become one PR. The main part of my PR is the loader, that is working under embroider :) I made the discovery of what API design this could land on (component vs. helper), but I don't have an opinion and as I saw @villander comment, I don't even have the reference to the RFC - but please make it either a helper or a component but not that weird hybrid thingy 🙈. Please make a decision, take the parts that are relevant and feel free to close my PR afterwards 👍 |
brought this up during the embroider team meeting and will attempt to summarize the discussion there currently isn't a clear way on how to get this to work with optimized emberoider scenarios as an alternative if services isolation is not an issue, the lazy loading aspect can be achieved in the form of converting the engine to a strict template v2 addon format and use existing lazy loading component techniques to achieve part of the benefits from this component/helper that's it for the summary, left a comment on the linked pr as well regarding dynamic imports if people want to invest time into something that is going to work only on classic builds or some non-optimised embroider scenarios (little benefit to be had from those) they are free to pursue this feature please note this work would need to land after ember source v5 compatibility lands together with the full ember try scenarios for it as well as embroider and would require all of those to pass in order to ensure users that are on those versions/setups would continue to work with the new release |
Extracted from https://github.com/buschtoens/ember-lazy-mount and slightly modernized.
Credit to @buschtoens for great work.