Breaking test: resetNamespace _within_ an engine's routes is broken #803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
resetNamespace:true
when mounting an engine works, but if the engine itself has routes withresetNamespace:true
, those routes get entirely stripped of their engine mount prefix, causing errors within link-to and any other place that needs to resolve the route name.In this PR,
post-reset-namespace
should have a route name ofblog.post-reset-namespace
but it gets registered (potentially multiple times if there are multiple mounts) as justpost-reset-namespace
, causing errors like:I suspect the fix might need to be in Ember proper, but this seemed like the right place to share.