fix(build): #405 don't call included() twice
#789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @buschtoens Could you please add test coverage for this, and also covering the |
|
@rwjblue could you please verify this PR? |
|
@brendenpalmer and I ran into this a bit ago, and it definitely seems like something we ought to try to address. The issue is that it isn't 100% clear that we don't want to call @buschtoens - Have you thought of that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405.
Fixes a bug where the
included()hook of any addon listed in an engine'sdependencieswould be called twice.See my comments in #405 for more details.
I have no clue, whether this is actually the correct fix, specifically with regards to
EMBER_ENGINES_ADDON_DEDUPEintroduced via #595. But it's working great for me.