build addon-test-support in engine #539
Conversation
kellyselden
force-pushed
the
test-support
branch
from
fcc46e5
to
5157108
Compare
kellyselden
changed the title
|
@kellyselden it works only when |
kellyselden
force-pushed
the
test-support
branch
from
5157108
to
447d262
Compare
|
@villander I just updated it to only create test-support.js in !== production, just like ember-cli does. |
kellyselden
force-pushed
the
test-support
branch
from
447d262
to
afca23c
Compare
|
@kellyselden make sense for me. This PR seems complement the #538, i'm right? |
|
They are independent. One is build env and the other is runtime env. |
|
You're right, they're different. Thanks for the solution, I think it looks great to be merged cc: @rwjblue |
kellyselden
force-pushed
the
test-support
branch
2 times, most recently
from
3347d24
to
6b352b2
Compare
kellyselden
force-pushed
the
test-support
branch
2 times, most recently
from
ebb0fda
to
b66d4a1
Compare
kellyselden
force-pushed
the
test-support
branch
from
b66d4a1
to
c5d0060
Compare
|
cc @simonihmig This fixes your addon ember-window-mock in engines. |
| output.contains('assets/node-asset-manifest.js'); | ||
| // Engine inherites its environment from the parent | ||
| output.contains( | ||
| `engines-dist/${engineName}/config/environment.js`, |
There was a problem hiding this comment.
@kellyselden could you add a test where we will ensure this behavior when we access the /tests route in the browser?
There was a problem hiding this comment.
I don't think it would be easy to test that. I think different environment building should be good.
There was a problem hiding this comment.
I also find it a difficult task, but unfortunately we need to ensure that your code works in this right scenario? It's the same problem as the #545
@rwjblue @stefanpenner any idea?
There was a problem hiding this comment.
@dgeb do you have any idea of how test this scenario?
|
@kellyselden Any movement on this PR? I know you have been in Japan having a fun! |
|
@kiwiupover I think it is done. |
|
@kellyselden can you solve these conflicts and add tests? please |
Addons like https://github.com/kaliber5/ember-window-mock won't work in an engine without building the test-support tree.
simonihmig/ember-window-mock#53