Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some script tag after-render #102

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add some script tag after-render #102

wants to merge 3 commits into from

Conversation

villander
Copy link
Member

@villander villander commented May 10, 2020 •
edited

It implements Add the script tag after-render

thanks, @stefanpenner for the hard work!

@villander
Copy link
Member Author

villander commented May 10, 2020 •
edited

Sometimes we have an issue with this test failing - resetLoadedAssetState removes new script tags, new link tags, and new modules

Also,test:sauce is failing.

cc: @dgeb @rwjblue

@rwjblue
Copy link
Member

rwjblue commented May 23, 2020

Have you debugged why that one test fails?

@villander
Copy link
Member Author

villander commented Jun 15, 2020 •
edited

@rwjblue I debugged, and there is no pattern to failure. I couldn't debug the sauce. Is there one way?

@rwjblue
Copy link
Member

rwjblue commented Jul 24, 2020

I couldn't debug the sauce. Is there one way?

Not sure...

@villander
Copy link
Member Author

@rwjblue can you add a label then with help wanted or something related?

@villander
Copy link
Member Author

villander commented Apr 8, 2021 •
edited

@rwjblue @dgeb do you have some time to debug the sauce?

I'm not sure what's going on here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@villander @rwjblue