fix(utils): [Edge 18] ensure function prototype

[buschtoens]

Fixes #417.

Apparently (starting with Edge 18?) Edge's JS engine performs some broken optimizations for the return value of decorator. The returned function somehow gets stripped off its Function prototype and instead gets Object.

This fix ensures the Function prototype for Edge.

[mfeckie]

Are there any blockers to getting this merged? (awesome that you've found a workable fix)

[buschtoens]

CI is acting up for unrelated reasons for the ember-beta and ember-canary build, it seems. I restarted them, but they still fail. ember-cli-dependency-checker for some reason cannot find the ember-data package. It might not be installed.

I'll try to fix this later today. Then somebody with npm publish access (@rwjblue and @pzuraq) can publish.

[mfeckie]

How we going here peeps?

[pzuraq]

@mfeckie sorry, it just hasn't been a priority since we have a lot of work to do to ship decorators/tracked properties upstream, and the recommendation is to upgrade to v6 which shouldn't have this issue 😕 If Jan can get tests passing and handle the deployment, I'm 👍 on landing this, but I'm not going to have time to look into it myself.

[buschtoens]

Unfortunately we already migrated all of our apps to v6 as well. 🙊

[mfeckie]

Yeah, I think that's what we're likely to do ... time permitting :)

[rwjblue]

Just wanted to clarify here, this PR targets the v5 branch but I'm not 100% sure why? Is it only applicable to v5?

[buschtoens]

@rwjblue that is correct. This issue only occurs with v5.

[kiwi-josh]

Hey folks, is there any chance we could get some movement on this? 🙏 I would be more than happy to help out where possible if time is the main blocker.

[pzuraq]

@wytlytningNZ unfortunately none of the maintainers have time to work on this issue, since it doesn't affect the current major release. Our recommendation is to upgrade to v6.

If you would like to take over this PR and get tests passing, that would be really helpful. At the least it would mean you could pin your package.json to a commit, if we still don't have time to merge and publish a patch version.

[buschtoens]

You can also use this hotfix: #417 (comment)

But I can only reiterate on @pzuraq's point. Rather try upgrading to v6 as quickly as possible, to avoid being locked in to and old and unmaintained state of the Ember ecosystem.