Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --active-only option to list command #517

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kellyselden
Copy link
Contributor

@kellyselden kellyselden commented Mar 30, 2020

We need a way to get the active revision, no matter how old it is. I don't think this is possible now, because you would need to know the amount beforehand. Right now we are working around the issue with:

    'display-revisions': {
      revisions(context) {
        if (process.env.ACTIVE_ONLY) {
          context.revisions = context.revisions.filter(revision => revision.active);
        }

        return context.revisions;
      },
    },

but we would like to upstream this behaviour.

Implementation PR ember-cli-deploy/ember-cli-deploy-display-revisions#23.

@lukemelia
Copy link
Contributor

@kellyselden I understand the need and this looks fine to me. In order to be merged, this PR should include:

We'll also need to:

  • Resolve unrelated travis build issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants