-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a new Dataset: Arabic Reviews of SHEIN #710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this addition!
I left some comments, also missing intfloat/multilingual-e5-small
results.
results/sentence-transformers__all-MiniLM-L6-v2/model_meta.json
Outdated
Show resolved
Hide resolved
results/sentence-transformers__all-MiniLM-L6-v2/OnlineStoreReviewSentimentClassification.json
Outdated
Show resolved
Hide resolved
mteb/tasks/Classification/ara/OnlineStoreReviewSentimentClassification.py
Outdated
Show resolved
Hide resolved
I did |
results/sentence-transformers__all-MiniLM-L6-v2/OnlineStoreReviewSentimentClassification.json
Outdated
Show resolved
Hide resolved
mteb/tasks/Classification/ara/OnlineStoreReviewSentimentClassification.py
Outdated
Show resolved
Hide resolved
mteb/tasks/Classification/ara/OnlineStoreReviewSentimentClassification.py
Outdated
Show resolved
Hide resolved
mteb/tasks/Classification/ara/OnlineStoreReviewSentimentClassification.py
Outdated
Show resolved
Hide resolved
mteb/tasks/Classification/ara/OnlineStoreReviewSentimentClassification.py
Outdated
Show resolved
Hide resolved
mteb/tasks/Classification/ara/OnlineStoreReviewSentimentClassification.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll let you update the points with the correct reviewers name and we'll be able to merge
Done .. is it ok? @imenelydiaker |
Question? |
No worries about this, LGTM, let's merge. |
@Ruqyai can you please run |
Done ..
I fixed them |
Checklist for adding MMTEB dataset
Reason for dataset addition:
mteb
package.mteb run -m {model_name} -t {task_name}
command.sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
intfloat/multilingual-e5-small
self.stratified_subsampling() under dataset_transform()
make test
.make lint
.438.jsonl
).