Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premai SDK integration #1367

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

Anindyadeep
Copy link

@Anindyadeep Anindyadeep commented May 15, 2024

Description

This PR adds a integration of premai python sdk to embedchain llms and embedder.

Fixes #1366
Fixes #1368

Type of change

  • New feature: Added premai python sdk
  • Documentation update to add premai python sdk
  • Schema validation support for custom llms and embedding models

How Has This Been Tested?

I have added tests and those are passing. You can also checkout this documentation part to reproduce it.

Please delete options that are not relevant.

  • Unit Test
  • Test Script ( here )

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@Anindyadeep Anindyadeep marked this pull request as draft May 15, 2024 11:42
@Anindyadeep Anindyadeep marked this pull request as ready for review May 16, 2024 11:54
@Anindyadeep Anindyadeep marked this pull request as draft May 16, 2024 17:48
@Anindyadeep Anindyadeep marked this pull request as ready for review May 18, 2024 05:34
@Anindyadeep
Copy link
Author

Hi @deshraj, it would be great, if we can start the review process for this, so that I can re-iterate.

Thanks and appreciate it.

ps: the code was very readible, devex experience was awesome with embedchain :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the feature to have custom config Add PremAI Python SDK
1 participant