-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added language detection for non-english youtube videos #1362
base: main
Are you sure you want to change the base?
Conversation
@anantoj thanks for providing that fix! I ran & reviewed your code locally ... it looks good to me. |
@LeonieFreisinger Thanks for pointing out the issue. I was not aware that the test suite uses a dummy |
@anantoj thanks for your fast answer! |
@LeonieFreisinger it seems that your video just doesn't have a transcript, which causes the issue. It's also a warning raised by |
@anantoj You are right! So it should be fine. |
@anantoj Can you please resolve the merge conflicts so that we can merge the PR? |
Hi @Dev-Khant, I've resolved the conflicts |
Description
Invoking
app.add()
on non-english youtube videos would cause aNoTranscriptFound
error. There is already a pull request that fixes the issue by specify an additional argument in the config file, but it has not been merged until today. Ideallyapp.add()
also automatically detects the language in the youtube transcript, instead having to manually specify the language in the beginning.Fixes #385
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I simply invoked
app.add()
on various non-english youtube videos, and theNoTranscriptFound
error no longer appears.Please delete options that are not relevant.
Checklist:
Maintainer Checklist