-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LanceDB Integration #1320
base: main
Are you sure you want to change the base?
LanceDB Integration #1320
Conversation
hey guys can we let this reviewed? Thanks! |
@PrashantDixit0 thanks for proposing these changes. I had a look at your code. There are 2 minor problems with the imports. tests/vectordb/test_lancedb.py:
Further, lancedb is not yet added to the |
@LeonieFreisinger Thank you for highlighting it, I have added these changes. Is it now good to merge? |
@PrashantDixit0 What example did you use to test your code? Can you provide me with a quick example and a sample config? Thanks. |
Sure @LeonieFreisinger, I'll add an example notebook in |
@LeonieFreisinger, I have added an example notebook and tested the whole flow. Is it good to merge? |
@deshraj Can you start reviewing it? |
Description
This PR adds LanceDB vector database.
Type of change
How Has This Been Tested?
I have written tests for the LanceDB vector database in
tests/vectordb/test_lancedb.py
Checklist:
Maintainer Checklist