[imp] pyls allows arguments passed to pylint #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just independently came up with almost exactly the same change: modified lsp-pyls.el
@@ -151,6 +151,13 @@ complexity."
:group 'lsp-pyls
:package-version '(lsp-mode . "6.1"))
+(defcustom lsp-pyls-plugins-pylint-args nil
+ "Command-line arguments to pylint."
+ :risky t
+ :type '(repeat string)
+ :group 'lsp-pyls
+ :package-version '(lsp-mode . "6.1"))
+
(defcustom lsp-pyls-plugins-pycodestyle-enabled t
"Enable or disable the plugin."
:type 'boolean
@@ -305,6 +312,7 @@ at all."
("pyls.plugins.pycodestyle.exclude" lsp-pyls-plugins-pycodestyle-exclude)
("pyls.plugins.pycodestyle.enabled" lsp-pyls-plugins-pycodestyle-enabled t)
("pyls.plugins.pylint.enabled" lsp-pyls-plugins-pylint-enabled t)
+ ("pyls.plugins.pylint.args" lsp-pyls-plugins-pylint-args)
("pyls.plugins.preload.modules" lsp-pyls-plugins-preload-modules)
("pyls.plugins.preload.enabled" lsp-pyls-plugins-preload-enabled t)
("pyls.plugins.mccabe.threshold" lsp-pyls-plugins-mccabe-threshold)I can confirm that this works for me, and that the tests pass with this change. I added Came across this while trying to solve palantir/python-language-server#616 (comment) |
mpanarin
changed the title
|
Thank you! |
jml
added a commit
to jml/dotfiles
that referenced
this pull request
Sep 17, 2019
Work around the issue palantir/python-language-server#616, which would be fixed by emacs-lsp/lsp-mode#928, but is not yet merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyls allows arguments passed to pylint: palantir/python-language-server#539