Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp-completion: support completion-lazy-hilit and quicker company-match #4394

Merged
merged 2 commits into from Apr 1, 2024

Conversation

kiennq
Copy link
Member

@kiennq kiennq commented Mar 24, 2024

Currently lsp-mode doesn't highlight the candidates in the way corfu supports.
This PR adds:

@sebastiencs
Copy link
Member

Finally, in the work-around for #4192, we can just use line-beginning-position as a guard for cached start point. That would be better than having a take whole long substring and then dissect it for the first line.

That seems good

support for completion-lazy-hilit

Cool, I didn't know that completion-lazy-hilit

@kiennq
Copy link
Member Author

kiennq commented Mar 26, 2024

@yyoncho Do you think you can merge this change?

@jcs090218
Copy link
Member

I've tried this patch, but the completion is no longer working. 🤔

@kiennq
Copy link
Member Author

kiennq commented Mar 31, 2024

I've tried this patch, but the completion is no longer working. 🤔

The completion via company-mode?

@jcs090218
Copy link
Member

The completion via company-mode?

Yes.

@kiennq
Copy link
Member Author

kiennq commented Apr 1, 2024

I've tried with emacs -Q and it seems still working fine.
The company configuration looks like this

(setenv "LSP_USE_PLISTS" "1")
(setq company-idle-delay 0.05
      company-minimum-prefix-length 2
      company-selection-wrap-around t
      company-require-match 'company-explicit-action-p
      company-backends `(company-capf))

@jcs090218
Copy link
Member

jcs090218 commented Apr 1, 2024

I've tried with emacs -Q and it seems still working fine.
The company configuration looks like this

Hmm... It's working this time. I'm not sure why it didn't work the first time I tested it. Sorry for the noise.

@kiennq kiennq merged commit 78f676f into emacs-lsp:master Apr 1, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants