Improve the default value of centaur-tabs-excluded-prefixes
#220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikmd
force-pushed
the
fix-excluded-buffers
branch
from
1f516d3
to
51028ac
Compare
|
FYI I've just amended my first commit to add another useful prefix… |
indeed, the following special buffers have a minimal size and are then not centaur-tabs compatible: - *Choices* for (ispell-word) - *Process List* for (list-processes) - *Calculator*, *Calc Trail* for (calc-dispatch)
Indeed: - as help-mode and helpful-mode buffers are expected to be "regular" buffers - all the more as they are part of the doc of `centaur-tabs-buffer-groups`: https://github.com/ema2159/centaur-tabs/blob/0bb1aa18d475319df85f192dce3327802866c3c3/README.org?plain=1#L234-L236
erikmd
force-pushed
the
fix-excluded-buffers
branch
from
51028ac
to
fc88414
Compare
erikmd
changed the title
centaur-tabs-excluded-prefixes
|
Hi @jcs090218 ! what's your opinion on this PR? it should be an easy one. Kind regards. |
jcs090218
reviewed
May 16, 2024
jcs090218
approved these changes
May 17, 2024
|
Thank you for the changes! :) |
|
Thank you for your time and for the merge! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @ema2159,
Thanks for maintaining this very nice mode! (BTW, I recently added it in the init file we propose to CS students.)
Just a small PR to propose two changes regarding centaur-tabs-excluded-prefixes that looked important to me → cf. the commits' messages
(and the following screenshot that deals with the first commit)
Screenshot before this PR: we cannot see the suggestions if the ispell buffer has only one line