Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add centaur-tabs-local-mode-if-enabled #169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DivineDominion
Copy link

@DivineDominion DivineDominion commented Dec 20, 2021

I am still experimenting with centaur-tabs-mode and found that the centair-tabs-local-mode hook from the README was a bit too invasive: when I turn (centaur-tabs-mode -1) off, then the local minor mode would error out. That resulted in my org agenda not displaying at all :)

My suggestion would be to add one of the following:

  1. to offer a function in the library that doesn't error out (this PR)
  2. to offer this function in the README example instead of the main lib
  3. to change the minor mode and just do nothing instead of erroring-out (would be my favorite to be honest, but not sure if this is intentional)

@ema2159 @nebhrajani-a What would you think is the best approach? Happy to amend the PR accordingly

@ema2159
Copy link
Owner

ema2159 commented Jan 11, 2022

Hi! I very much appreciate your PR, however, is it really necessary to add a new function? Wouldn't it be easier to just write the following for your hooks?

(lambda () ((when centaur-tabs-mode
    (centaur-tabs-local-mode)))

@DivineDominion
Copy link
Author

@ema2159 I'm now more leaning towards making the minor-mode not error out instead of adding this band-aid. Do you have an opinion on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants