Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enables translations #216

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

ChrisLaRocque
Copy link

This PR enables the Elysia docs to be translated into multiple languages and begin to accept PRs for translations. This should not be merged as-is, as it requires redirects to be set up to handle the new paths as well as fallbacks when pages aren't present. I'd also assume that the redirects you folks have set up for the top-level domain would need to be checked out.

I'd be happy to implement the redirects myself, but it appears that whatever redirects are currently happening are not managed in the codebase. If I can get some insight on how the redirects are currently managed I can help advise or implement.

@kravetsone
Copy link
Contributor

I don't think that's a good idea. The documentation is still not in the best condition, and so you will have to monitor the translations...

It will be difficult to maintain this...

@ChrisLaRocque ChrisLaRocque changed the title WIP: Enables translations feat: Enables translations Dec 28, 2023
@ChrisLaRocque
Copy link
Author

I don't think that's a good idea. The documentation is still not in the best condition, and so you will have to monitor the translations...

It will be difficult to maintain this...

Respectfully disagree, the only 'gotcha' would be if someone copies an EN doc but doesn't translate the entire doc. Otherwise the EN docs would just be a starting point that can be improved in each native language, while still being improved on their own.

@itsmeeudrino
Copy link

It'd be great if we can merge this, i'm also interested in bringing the docs to other languages (Arabic)
is there a reason we're holding this?

@bogeychan
Copy link
Collaborator

@itsmeeudrino, as @kravetsone already mentioned, elysia is still under development, therefore it is not worth working on translations yet

@kravetsone
Copy link
Contributor

But when the time comes, I could do the translation into Russian)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants