New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
few syntax improvements #63
base: master
Are you sure you want to change the base?
Conversation
…e which is most evil on most embedded platforms (read vendor run-time libs)
Hi, Thanks for your PR. I understand what ed74533 and b62616b are fixing, but I'd rather not modify the original Lua sources unless really needed (becuase that would make applying (and extracting) patches much harder). About 7aa2e45, I'm not sure about its scope, is it fixing an actual problem? Thanks, |
it removes dependency on locale.h which is not necessarily available on embedded platforms and is not required for the absanse of float numbers |
…on integers (missed a file)
That makes sense, thank you. I'll take the commit(s) that remove the dependency on locale.h, but as mentioned before, I'd rather not merge the ones related to toolchain compatibility improvement, or other such commits that change the base Lua code without a very good reason to do so. |
Two added notes:
For example: https://github.com/jsnyder/lua/blob/master/src/lapi.c#L926 vs ed74533 That said, I believe what we have is still valid C99. Also the Lua Tiny RAM patches that allow for read-only tables that conserve SRAM are built using designated initializers which bump our compiler requirement up to C99 anyways. |
improve some of the compiler compatibility and get rid of the dead code