Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v: Update to V 0.4.5 ed7f1ff #196

Merged
merged 1 commit into from
Apr 21, 2024
Merged

v: Update to V 0.4.5 ed7f1ff #196

merged 1 commit into from
Apr 21, 2024

Conversation

elliotchance
Copy link
Owner

@elliotchance elliotchance commented Apr 20, 2024

This aggregates the awesome work by @ttytm in #192, #193, #194 and #195.

Copy link
Contributor

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

@ttytm
Copy link
Contributor

ttytm commented Apr 20, 2024

Would be even more excellent if at least a tiny attribution would be left as includes and supersedes open PRs

@elliotchance
Copy link
Owner Author

@ttytm - I didn't want to land multiple PRs that were broken individually broken builds. I was going to add a description crediting the other PRs before this landed, but since this all your work I'm happy for you to resubmit the patch and I'll close this one so it can be actually signed under you.

@ttytm
Copy link
Contributor

ttytm commented Apr 20, 2024

@ttytm - I didn't want to land multiple PRs that were broken individually broken builds. I was going to add a description crediting the other PRs before this landed, but since this all your work I'm happy for you to resubmit the patch and I'll close this one so it can be actually signed under you.

Thank you. Mentioning it as a principle is just what was important to me. Gaining a personal attribution from it, less, I don't have too much control over that.

@elliotchance elliotchance merged commit 5f7596e into main Apr 21, 2024
8 checks passed
@elliotchance elliotchance deleted the v-up-5 branch April 21, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants