Support for builtin orm #90
Labels
enhancement
New feature or request
Milestone
Comments
|
Would you like to implement it? |
|
@N0tExisting turns out this is not possible right now because the drivers need to be hard coded into the V codebase. |
Looking at the code, it seems like it is only used to prefix the name, so it could be refactored to allow any name. P.S: I can't implement it because I'm studying for my final exams atm |
|
There's no rush, here was my initial investigation: de83efa |
elliotchance
added a commit
that referenced
this issue
Jun 20, 2022
DO NOT MERGE. This is partial support for the ORM. However, there are some challenges that need to be addressed before this can be properly reviewed and landed: 1. The ORM in V requires drivers to be hard-coded. See #90. 2. The Connection doesn't _really_ implement orm.Connection because the vsql Connection is required to be mut and the current interface definition does not allow this. 3. We need to create a new test suite for the ORM. `vsql/orm_test.v` filled with combinations of statements "sql" commands will work just fine. Specifically, we need to test different combinations of expressions and types. Fixes #90
|
I have created a PR #102 but there are some other problems that need to be addressed before I can work on it further. |
elliotchance
added a commit
that referenced
this issue
Dec 30, 2023
DO NOT MERGE. This is partial support for the ORM. However, there are some challenges that need to be addressed before this can be properly reviewed and landed: 1. The ORM in V requires drivers to be hard-coded. See #90. 2. The Connection doesn't _really_ implement orm.Connection because the vsql Connection is required to be mut and the current interface definition does not allow this. 3. We need to create a new test suite for the ORM. `vsql/orm_test.v` filled with combinations of statements "sql" commands will work just fine. Specifically, we need to test different combinations of expressions and types. Fixes #90
elliotchance
added a commit
that referenced
this issue
Dec 30, 2023
DO NOT MERGE. This is partial support for the ORM. However, there are some challenges that need to be addressed before this can be properly reviewed and landed: 1. The ORM in V requires drivers to be hard-coded. See #90. 2. The Connection doesn't _really_ implement orm.Connection because the vsql Connection is required to be mut and the current interface definition does not allow this. 3. We need to create a new test suite for the ORM. `vsql/orm_test.v` filled with combinations of statements "sql" commands will work just fine. Specifically, we need to test different combinations of expressions and types. Fixes #90
elliotchance
added a commit
that referenced
this issue
Dec 31, 2023
DO NOT MERGE. This is partial support for the ORM. However, there are some challenges that need to be addressed before this can be properly reviewed and landed: 1. The ORM in V requires drivers to be hard-coded. See #90. 2. The Connection doesn't _really_ implement orm.Connection because the vsql Connection is required to be mut and the current interface definition does not allow this. 3. We need to create a new test suite for the ORM. `vsql/orm_test.v` filled with combinations of statements "sql" commands will work just fine. Specifically, we need to test different combinations of expressions and types. Fixes #90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently all builtin databases support the orm, and it would be nice if this one does too.
Needed for support:
orm.ConnectionThe text was updated successfully, but these errors were encountered: