Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First commit of redis cache utilising predis #3708

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

tinoest
Copy link
Contributor

@tinoest tinoest commented Apr 10, 2023

@Spuds not sure if you want this as part of the core, or if I am doing this the right way.

The ip for the redis server is hardcoded currently, so if you do a checkout edit this line to what your ip is to get it working.

$this->obj = new \Predis\Client('tcp://172.19.0.5:6379');

I will change and work out how to add multiple different servers if you are happy using predis. It seems to work ok otherwise.

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage: 53.33% and project coverage change: +0.17 🎉

Comparison is base (c5730e1) 30.45% compared to head (fa128c0) 30.62%.

Additional details and impacted files
@@                Coverage Diff                @@
##             development    #3708      +/-   ##
=================================================
+ Coverage          30.45%   30.62%   +0.17%     
- Complexity         16416    16445      +29     
=================================================
  Files                429      430       +1     
  Lines              84387    84372      -15     
=================================================
+ Hits               25703    25843     +140     
+ Misses             58684    58529     -155     
Impacted Files Coverage Δ
...rces/ElkArte/AdminController/ManageAttachments.php 8.74% <ø> (ø)
sources/ElkArte/AdminController/ManageFeatures.php 18.25% <0.00%> (ø)
sources/ElkArte/AttachmentsDirectory.php 9.90% <ø> (ø)
sources/ElkArte/Controller/Attachment.php 9.58% <0.00%> (ø)
sources/ElkArte/Controller/Groups.php 29.48% <0.00%> (ø)
sources/ElkArte/Controller/ModerateAttachments.php 0.00% <0.00%> (ø)
sources/ElkArte/Controller/Stats.php 0.00% <0.00%> (ø)
sources/ElkArte/Modules/Attachments/Display.php 100.00% <ø> (ø)
sources/ElkArte/Modules/Random/Display.php 83.33% <ø> (ø)
sources/ElkArte/SettingsForm/SettingsForm.php 100.00% <ø> (ø)
... and 16 more

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant