New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added: Faker.Blockchain.CryptoCoin #259
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a blockchain namespace. @thadeubrito do you think this new faker module could be moved to this namespace?
I think this data is useful @igas @anthonator what do you guys think?
yes, it could be there. thanks @vbrazo |
Well done! |
@@ -10,6 +10,7 @@ | |||
- [Faker.Beer](lib/faker/beer.ex) | |||
- [Faker.Beer.En](lib/faker/beer/en.ex) | |||
- [Faker.Blockchain.Bitcoin](lib/faker/bitcoin.ex) | |||
- [Faker.BlockChain.CryptoCoin](lib/faker/blockchain/crypto_coin.ex) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be Faker.Blockchain
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thadeubrito could you make this change?
@thadeubrito could you resolve the outstanding conflicts? |
I've added: