Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Date to accept year outside ISO8601 range #13551

Merged
merged 5 commits into from May 11, 2024

Conversation

cocoa-xu
Copy link
Contributor

Based on the discussion in elixir-explorer/adbc#74, this PR

  • allows Date to accept year outside the ISO8601 range
  • relaxes the year guards -- as long as it's an integer
  • relaxes the days guard in Calendar.ISO.date_from_iso_days/1, so that we can do computations like Date.add/1
  • prints as Date.new! instead of the sigil if the date is outside the ISO8601 range

@josevalim josevalim merged commit 3d7f4dd into elixir-lang:main May 11, 2024
8 of 9 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants