Change how CI jobs are canceled #13419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds two changes: 1. It introduces `concurrency:` flag to the workflow, to cancel older jobs for the same branch. It is really helpful for PRs, so no stale jobs will continue to operate when new commits are pushed to the same branch 2. I've added `fail-fast: false` to Windows jobs to be in sync with other jobs
sobolevn
changed the title
josevalim
reviewed
Mar 19, 2024
josevalim
reviewed
Mar 19, 2024
Co-authored-by: José Valim <jose.valim@gmail.com>
|
Thank you @sobolevn for the PR! We will take it from here. :) |
yordis
reviewed
Mar 20, 2024
Co-authored-by: Yordis Prieto <yordis.prieto@gmail.com>
|
I will close this for now. Since we don't want cancel in progress, the default behaviour seems to be unbounded concurrency, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two changes:
concurrency:flag to the workflow, to cancel older jobs for the same branch. It is really helpful for PRs, so no stale jobs will continue to operate when new commits are pushed to the same branchfail-fast: falseto Windows jobs to be in sync with other jobs