Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add author roxannemcd #920

Merged
merged 5 commits into from Apr 18, 2023
Merged

add author roxannemcd #920

merged 5 commits into from Apr 18, 2023

Conversation

ElevenTom
Copy link
Contributor

No description provided.

@github-actions github-actions bot temporarily deployed to dev-feat/add-author-roxannemcd April 11, 2023 14:19 Destroyed
@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2023

⚡️🏠 Lighthouse report

Here's the summary:

Path Performance Accessibility Best practices SEO PWA
/feat/add-author-roxannemcd/ 🟠 62 🟠 73 🟠 83 🟢 92 🟠 60
/feat/add-author-roxannemcd/fr/authors/ajacquemin/ 🟠 65 🟠 73 🟠 75 🟢 92 🟠 60
/feat/add-author-roxannemcd/fr/comment-construire-site-web-avec-nextjs/ 🔴 49 🟠 76 🟠 83 🟢 100 🟠 60
/feat/add-author-roxannemcd/fr/nestjs-le-cycle-de-vie-dune-requete/ 🟠 78 🟠 76 🟠 75 🟢 97 🟠 60

Here's the audits:

Path FCP
1800 <=
LCP
2500 <=
Speed Index
3400 <=
TTI
3800 <=
TBT
200 <=
CLS
0.1 <=
/feat/add-author-roxannemcd/ 🔴 2695 🔴 11918 🟢 2705 🔴 12248 🟢 35 🟢 0
/feat/add-author-roxannemcd/fr/authors/ajacquemin/ 🔴 2034 🔴 11238 🟢 2397 🔴 11567 🟢 51 🟢 0
/feat/add-author-roxannemcd/fr/comment-construire-site-web-avec-nextjs/ 🔴 2490 🔴 3842 🟢 3370 🔴 14174 🔴 1381 🟢 0
/feat/add-author-roxannemcd/fr/nestjs-le-cycle-de-vie-dune-requete/ 🔴 2245 🔴 2622 🟢 2828 🔴 12143 🔴 244 🟢 0

layout: author
login: RoxanneMcd
title: Roxanne Marchand
github: https://github.com/meugeniatr/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne pense pas que ca soit son github ;)

@@ -0,0 +1,10 @@
---
layout: author
login: RoxanneMcd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sans majuscule, le meme quand dans l'url

@github-actions github-actions bot temporarily deployed to dev-feat/add-author-roxannemcd April 11, 2023 14:34 Destroyed
Copy link
Member

@Pouzor Pouzor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

le fichier n'a pas le bon nom (par rapport au author, et il manque le .md sur le fichier)

@github-actions github-actions bot temporarily deployed to dev-feat/add-author-roxannemcd April 11, 2023 15:06 Destroyed
@github-actions github-actions bot temporarily deployed to dev-feat/add-author-roxannemcd April 11, 2023 16:03 Destroyed
@github-actions github-actions bot temporarily deployed to dev-feat/add-author-roxannemcd April 18, 2023 13:00 Destroyed
@Pouzor Pouzor merged commit 75582ff into master Apr 18, 2023
2 checks passed
@Pouzor Pouzor deleted the feat/add-author-roxannemcd branch April 18, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants