Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iframe video and icons in firefox #1122

Merged
merged 1 commit into from May 3, 2024

Conversation

fpasquet
Copy link
Contributor

@fpasquet fpasquet commented May 3, 2024

No description provided.

@fpasquet fpasquet added status/mergeable status: mergeable status/reviewable status: reviewable labels May 3, 2024
@fpasquet fpasquet self-assigned this May 3, 2024
@fpasquet fpasquet deployed to 1122/merge May 3, 2024 08:48 — with GitHub Actions Active
@github-actions github-actions bot temporarily deployed to fix/iframe-video-icons-firefox May 3, 2024 08:52 Destroyed
Copy link
Contributor

github-actions bot commented May 3, 2024

⚡️🏠 Lighthouse report

Here's the summary:

Path Performance Accessibility Best practices SEO PWA
/fix/iframe-video-icons-firefox/ 🟢 94 🟢 90 🟢 100 🟢 92 🟠 70
/fix/iframe-video-icons-firefox/fr/authors/ajacquemin/ 🟠 74 🟢 90 🟢 100 🟢 92 🟠 70
/fix/iframe-video-icons-firefox/fr/comment-construire-site-web-avec-nextjs/ 🟠 76 🟠 80 🟢 100 🟢 100 🟠 70
/fix/iframe-video-icons-firefox/fr/nestjs-le-cycle-de-vie-dune-requete/ 🟠 72 🟠 80 🟢 100 🟢 97 🟠 70

Here's the audits:

Path FCP
1800 <=
LCP
2500 <=
Speed Index
3400 <=
TTI
3800 <=
TBT
200 <=
CLS
0.1 <=
/fix/iframe-video-icons-firefox/ 🔴 1850 🟢 1859 🟢 1940 🔴 4109 🟢 7 🔴 0.12
/fix/iframe-video-icons-firefox/fr/authors/ajacquemin/ 🔴 2215 🔴 2520 🟢 2703 🔴 4071 🟢 9 🟢 0.01
/fix/iframe-video-icons-firefox/fr/comment-construire-site-web-avec-nextjs/ 🔴 2376 🔴 2826 🟢 2433 🔴 4193 🟢 6 🟢 0.03
/fix/iframe-video-icons-firefox/fr/nestjs-le-cycle-de-vie-dune-requete/ 🔴 2000 🟢 2000 🟢 2421 🔴 4215 🟢 7 🟢 0.04

@fpasquet fpasquet merged commit bd5a11c into master May 3, 2024
9 checks passed
@fpasquet fpasquet deleted the fix/iframe-video-icons-firefox branch May 3, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/mergeable status: mergeable status/reviewable status: reviewable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant