Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken links and images and tutorial previous button #1117

Merged
merged 3 commits into from Apr 25, 2024

Conversation

seinhorn
Copy link
Contributor

No description provided.

@seinhorn seinhorn requested a review from fpasquet April 22, 2024 11:02
@github-actions github-actions bot temporarily deployed to fix/broken-links-and-images April 22, 2024 11:07 Destroyed
Copy link
Contributor

github-actions bot commented Apr 22, 2024

⚡️🏠 Lighthouse report

Here's the summary:

Path Performance Accessibility Best practices SEO PWA
/fix/broken-links-and-images/ 🟢 91 🟢 90 🟢 100 🟢 92 🟠 70
/fix/broken-links-and-images/fr/authors/ajacquemin/ 🟠 71 🟢 90 🟢 100 🟠 85 🟠 70
/fix/broken-links-and-images/fr/comment-construire-site-web-avec-nextjs/ 🟠 74 🟠 80 🟢 100 🟢 100 🟠 70
/fix/broken-links-and-images/fr/nestjs-le-cycle-de-vie-dune-requete/ 🟠 72 🟠 80 🟢 100 🟢 97 🟠 70

Here's the audits:

Path FCP
1800 <=
LCP
2500 <=
Speed Index
3400 <=
TTI
3800 <=
TBT
200 <=
CLS
0.1 <=
/fix/broken-links-and-images/ 🔴 2268 🟢 2289 🟢 2268 🔴 4021 🟢 6 🔴 0.12
/fix/broken-links-and-images/fr/authors/ajacquemin/ 🔴 2237 🔴 2543 🟢 2868 🔴 4058 🟢 7 🟢 0.01
/fix/broken-links-and-images/fr/comment-construire-site-web-avec-nextjs/ 🔴 2380 🔴 2677 🟢 2433 🔴 4128 🟢 6 🟢 0.03
/fix/broken-links-and-images/fr/nestjs-le-cycle-de-vie-dune-requete/ 🔴 1985 🟢 2431 🟢 2427 🔴 4180 🟢 7 🟢 0.04

@seinhorn seinhorn changed the title fix: broken links and images and tutotirial previous button fix: broken links and images and tutorial previous button Apr 23, 2024
@github-actions github-actions bot temporarily deployed to fix/broken-links-and-images April 23, 2024 09:59 Destroyed
@fpasquet fpasquet force-pushed the fix/broken-links-and-images branch from dfe282c to c732486 Compare April 25, 2024 12:21
@fpasquet fpasquet merged commit 52525ed into master Apr 25, 2024
2 checks passed
@fpasquet fpasquet deleted the fix/broken-links-and-images branch April 25, 2024 12:21
@fpasquet fpasquet added status/mergeable status: mergeable status/reviewable status: reviewable labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/mergeable status: mergeable status/reviewable status: reviewable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants