Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: generate image with sharp #1091

Merged
merged 1 commit into from Apr 16, 2024

Conversation

fpasquet
Copy link
Contributor

No description provided.

@fpasquet fpasquet force-pushed the refactor/generate-image-with-sharp branch from 642dadc to 33714ca Compare April 10, 2024 15:21
@fpasquet fpasquet self-assigned this Apr 10, 2024
@fpasquet fpasquet added status/mergeable status: mergeable status/reviewable status: reviewable labels Apr 10, 2024
@github-actions github-actions bot temporarily deployed to refactor/generate-image-with-sharp April 10, 2024 15:25 Destroyed
Copy link
Contributor

github-actions bot commented Apr 10, 2024

⚡️🏠 Lighthouse report

Here's the summary:

Path Performance Accessibility Best practices SEO PWA
/refactor/generate-image-with-sharp/ 🟢 90 🟢 90 🟢 100 🟢 100 🟠 70
/refactor/generate-image-with-sharp/fr/authors/ajacquemin/ 🟠 88 🟢 90 🟢 100 🟢 92 🟠 70
/refactor/generate-image-with-sharp/fr/comment-construire-site-web-avec-nextjs/ 🟠 80 🟠 80 🟢 100 🟢 100 🟠 70
/refactor/generate-image-with-sharp/fr/nestjs-le-cycle-de-vie-dune-requete/ 🟢 94 🟠 80 🟢 100 🟢 97 🟠 70

Here's the audits:

Path FCP
1800 <=
LCP
2500 <=
Speed Index
3400 <=
TTI
3800 <=
TBT
200 <=
CLS
0.1 <=
/refactor/generate-image-with-sharp/ 🔴 2397 🟢 2415 🟢 2738 🔴 4311 🟢 6 🔴 0.12
/refactor/generate-image-with-sharp/fr/authors/ajacquemin/ 🔴 2529 🔴 2529 🟢 3059 🔴 4214 🟢 6 🟢 0.01
/refactor/generate-image-with-sharp/fr/comment-construire-site-web-avec-nextjs/ 🔴 2087 🔴 2696 🟢 2087 🔴 4698 🟢 6 🟢 0.03
/refactor/generate-image-with-sharp/fr/nestjs-le-cycle-de-vie-dune-requete/ 🔴 2086 🟢 2143 🟢 2086 🔴 4712 🟢 6 🟢 0.04

@fpasquet fpasquet force-pushed the refactor/generate-image-with-sharp branch from 33714ca to 36285e3 Compare April 11, 2024 07:43
@fpasquet fpasquet requested a review from ch3ric April 11, 2024 07:47
@github-actions github-actions bot temporarily deployed to refactor/generate-image-with-sharp April 11, 2024 07:48 Destroyed
@fpasquet fpasquet force-pushed the refactor/generate-image-with-sharp branch 2 times, most recently from d8dbaf2 to 031fe05 Compare April 13, 2024 17:55
@github-actions github-actions bot temporarily deployed to refactor/generate-image-with-sharp April 13, 2024 17:59 Destroyed
@github-actions github-actions bot temporarily deployed to refactor/generate-image-with-sharp April 13, 2024 18:00 Destroyed
@github-actions github-actions bot temporarily deployed to refactor/generate-image-with-sharp April 14, 2024 08:12 Destroyed
@fpasquet fpasquet force-pushed the refactor/generate-image-with-sharp branch from 8741a01 to 74c651c Compare April 14, 2024 11:45
@github-actions github-actions bot temporarily deployed to refactor/generate-image-with-sharp April 14, 2024 11:50 Destroyed
@fpasquet fpasquet force-pushed the refactor/generate-image-with-sharp branch from 74c651c to 3d4725a Compare April 14, 2024 12:16
@github-actions github-actions bot temporarily deployed to refactor/generate-image-with-sharp April 14, 2024 12:21 Destroyed
@fpasquet fpasquet force-pushed the refactor/generate-image-with-sharp branch from 3d4725a to a4ddc76 Compare April 15, 2024 07:40
@fpasquet fpasquet requested a review from seinhorn April 15, 2024 07:45
@github-actions github-actions bot temporarily deployed to refactor/generate-image-with-sharp April 15, 2024 07:46 Destroyed
src/translations/en.translations.json Outdated Show resolved Hide resolved
src/helpers/assetHelper.ts Show resolved Hide resolved
src/translations/fr.translations.json Show resolved Hide resolved
@fpasquet fpasquet force-pushed the refactor/generate-image-with-sharp branch from a4ddc76 to 091cc3c Compare April 15, 2024 19:49
@github-actions github-actions bot temporarily deployed to refactor/generate-image-with-sharp April 15, 2024 19:54 Destroyed
@fpasquet fpasquet merged commit 6d32d0d into master Apr 16, 2024
9 checks passed
@fpasquet fpasquet deleted the refactor/generate-image-with-sharp branch April 16, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/mergeable status: mergeable status/reviewable status: reviewable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants