Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: apply new design #1051

Closed
wants to merge 23 commits into from
Closed

feat: apply new design #1051

wants to merge 23 commits into from

Conversation

fpasquet
Copy link
Contributor

@fpasquet fpasquet commented Jan 4, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 35.7%, saving 11.82 KB.

Filename Before After Improvement Visual comparison
public/imgs/contact-background.png 33.09 KB 21.28 KB -35.7% View diff

1160 images did not require optimisation.

@fpasquet fpasquet changed the base branch from master to feat/upgrade-design-system January 4, 2024 13:19
@fpasquet fpasquet changed the base branch from feat/upgrade-design-system to feat/update-design-system January 4, 2024 13:20
@fpasquet fpasquet changed the title Feat/apply new design feat: apply new design Jan 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 35.7%, saving 11.82 KB.

Filename Before After Improvement Visual comparison
public/imgs/contact-background.png 33.09 KB 21.28 KB -35.7% View diff

1160 images did not require optimisation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 35.7%, saving 11.82 KB.

Filename Before After Improvement Visual comparison
public/imgs/contact-background.png 33.09 KB 21.28 KB -35.7% View diff

1160 images did not require optimisation.

@fpasquet fpasquet force-pushed the feat/update-design-system branch 7 times, most recently from c10f153 to 286b894 Compare January 4, 2024 14:54
@fpasquet fpasquet added status/mergeable status: mergeable status/reviewable status: reviewable labels Jan 4, 2024
@fpasquet fpasquet self-assigned this Jan 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 35.7%, saving 11.82 KB.

Filename Before After Improvement Visual comparison
public/imgs/contact-background.png 33.09 KB 21.28 KB -35.7% View diff

1160 images did not require optimisation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 35.7%, saving 11.82 KB.

Filename Before After Improvement Visual comparison
public/imgs/contact-background.png 33.09 KB 21.28 KB -35.7% View diff

1160 images did not require optimisation.

@github-actions github-actions bot temporarily deployed to dev-feat/apply-new-design January 4, 2024 15:59 Destroyed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024 •
edited

⚡️🏠 Lighthouse report

Here's the summary:

Path Performance Accessibility Best practices SEO PWA
/feat/apply-new-design/ 🟠 85 🟢 90 🟠 83 🟢 92 🟠 70
/feat/apply-new-design/fr/authors/ajacquemin/ 🟠 74 🟢 90 🟠 75 🟢 92 🟠 70
/feat/apply-new-design/fr/comment-construire-site-web-avec-nextjs/ 🟠 85 🟠 80 🟢 92 🟢 100 🟠 70
/feat/apply-new-design/fr/nestjs-le-cycle-de-vie-dune-requete/ 🟠 89 🟠 80 🟢 92 🟢 97 🟠 70

Here's the audits:

Path FCP
1800 <=		 LCP
2500 <=		 Speed Index
3400 <=		 TTI
3800 <=		 TBT
200 <=		 CLS
0.1 <=
/feat/apply-new-design/ 🔴 2675 🔴 2675 🟢 2675 🔴 5944 🟢 8 🔴 0.1
/feat/apply-new-design/fr/authors/ajacquemin/ 🔴 2665 🔴 4944 🟢 2665 🔴 5749 🟢 8 🟢 0.01
/feat/apply-new-design/fr/comment-construire-site-web-avec-nextjs/ 🔴 2893 🔴 2893 🟢 2893 🔴 7312 🟢 8 🟢 0.01
/feat/apply-new-design/fr/nestjs-le-cycle-de-vie-dune-requete/ 🔴 2654 🔴 2654 🟢 2654 🔴 6147 🟢 8 🟢 0.01

@github-actions github-actions bot temporarily deployed to dev-feat/apply-new-design January 29, 2024 16:01 Destroyed
@github-actions GitHub Actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 29%, saving 264.88 KB.

Filename Before After Improvement Visual comparison
src/assets/imgs/cover-article.jpg 914.07 KB 649.19 KB -29.0% View diff

1153 images did not require optimisation.

@github-actions github-actions bot temporarily deployed to dev-feat/apply-new-design January 29, 2024 16:18 Destroyed
@github-actions GitHub Actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 29%, saving 264.88 KB.

Filename Before After Improvement Visual comparison
src/assets/imgs/cover-article.jpg 914.07 KB 649.19 KB -29.0% View diff

1153 images did not require optimisation.

@github-actions github-actions bot temporarily deployed to dev-feat/apply-new-design January 29, 2024 17:18 Destroyed
@github-actions GitHub Actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 29%, saving 264.88 KB.

Filename Before After Improvement Visual comparison
src/assets/imgs/cover-article.jpg 914.07 KB 649.19 KB -29.0% View diff

1153 images did not require optimisation.

@github-actions github-actions bot temporarily deployed to dev-feat/apply-new-design January 30, 2024 07:28 Destroyed
@github-actions GitHub Actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 29%, saving 264.88 KB.

Filename Before After Improvement Visual comparison
src/assets/imgs/cover-article.jpg 914.07 KB 649.19 KB -29.0% View diff

1153 images did not require optimisation.

@github-actions github-actions bot temporarily deployed to dev-feat/apply-new-design January 30, 2024 07:39 Destroyed
@github-actions GitHub Actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 29%, saving 264.88 KB.

Filename Before After Improvement Visual comparison
src/assets/imgs/cover-article.jpg 914.07 KB 649.19 KB -29.0% View diff

1153 images did not require optimisation.

@github-actions GitHub Actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 26%, saving 391.60 KB.

Filename Before After Improvement Visual comparison
_assets/articles/2023-11-27-rex-custom-components-react-varnish-esi/cover.jpg 275.04 KB 228.84 KB -16.8% View diff
_assets/articles/2023-11-28-construire-un-design-system-robuste-avec-react-les-fondations-essentielles/cover.jpg 316.04 KB 235.52 KB -25.5% View diff
src/assets/imgs/cover-article.jpg 914.07 KB 649.19 KB -29.0% View diff

1154 images did not require optimisation.

@github-actions GitHub Actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 26%, saving 391.60 KB.

Filename Before After Improvement Visual comparison
_assets/articles/2023-11-27-rex-custom-components-react-varnish-esi/cover.jpg 275.04 KB 228.84 KB -16.8% View diff
_assets/articles/2023-11-28-construire-un-design-system-robuste-avec-react-les-fondations-essentielles/cover.jpg 316.04 KB 235.52 KB -25.5% View diff
src/assets/imgs/cover-article.jpg 914.07 KB 649.19 KB -29.0% View diff

1154 images did not require optimisation.

@github-actions github-actions bot temporarily deployed to dev-feat/apply-new-design January 30, 2024 10:49 Destroyed
@github-actions GitHub Actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 26%, saving 391.60 KB.

Filename Before After Improvement Visual comparison
_assets/articles/2023-11-27-rex-custom-components-react-varnish-esi/cover.jpg 275.04 KB 228.84 KB -16.8% View diff
_assets/articles/2023-11-28-construire-un-design-system-robuste-avec-react-les-fondations-essentielles/cover.jpg 316.04 KB 235.52 KB -25.5% View diff
src/assets/imgs/cover-article.jpg 914.07 KB 649.19 KB -29.0% View diff

1154 images did not require optimisation.

ch3ric
ch3ric reviewed Feb 6, 2024
View reviewed changes
src/helpers/dataLayerHelper.ts
dataAttributeValue?: string;
}

const clickEvents: ClickEventType[] = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tracking clicks is not needed anymore?

@fpasquet fpasquet deleted the branch feat/update-design-system April 11, 2024 11:48
@fpasquet fpasquet closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch3ric ch3ric ch3ric approved these changes

@RedHotMan RedHotMan RedHotMan approved these changes

Assignees

@fpasquet fpasquet

Labels
No merge status/reviewable status: reviewable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fpasquet @ch3ric @RedHotMan