Internal: Enable different top section content for Free/Pro Users on the Home screen [ED-14519] #27301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the Home screen [ED-14519]
| $this->has_pro = Utils::has_pro(); | ||
| } | ||
|
|
||
| private function valid_item( $item ) { |
There was a problem hiding this comment.
Maybe is_valid_item ?
| } | ||
|
|
||
| public function transform( array $home_screen_data ): array { | ||
| if ( is_array( $home_screen_data['top'] ) && count( $home_screen_data['top'] ) > 1 && is_array( $home_screen_data['top'][0] ) ) { |
There was a problem hiding this comment.
Can you reduce nesting ?
| } | ||
|
|
||
| public function transform( array $home_screen_data ): array { | ||
| if ( is_array( $home_screen_data['top'] ) && count( $home_screen_data['top'] ) > 1 && is_array( $home_screen_data['top'][0] ) ) { |
There was a problem hiding this comment.
Maybe extract this condition to a function that explains the check ?
| $new_top = []; | ||
|
|
||
| foreach ( $home_screen_data['top'] as $index => $item ) { | ||
| if ( $this->valid_item( $item ) ) { |
There was a problem hiding this comment.
Maybe extract this to a function that dies the check and pushes to the array if the check passed
hein-obox
reviewed
May 15, 2024
| } | ||
| } | ||
|
|
||
| $home_screen_data['top_with_licences'] = reset( $new_top ); |
There was a problem hiding this comment.
We can remove the 'top' data.
And please check indentation.
Suggested change
| $home_screen_data['top_with_licences'] = reset( $new_top ); | |
| $home_screen_data['top_with_licences'] = reset( $new_top ); | |
| unset( $home_screen_data['top'] ); |
hein-obox
reviewed
May 15, 2024
|
|
||
| $home_screen_data['top_with_licences'] = reset( $new_top ); | ||
|
|
||
| return $home_screen_data; |
There was a problem hiding this comment.
Suggested change
| return $home_screen_data; | |
| return $home_screen_data; |
hein-obox
reviewed
May 15, 2024
hein-obox
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.