Internal: Conversion Center - Link in Bio - full height fix #27277
Conversation
…in CSS with updated selector pattern in PHP
…tion for full ehight control
| 'default' => 'cover', | ||
| ], | ||
| 'position' => [ | ||
| 'default' => 'center center', |
There was a problem hiding this comment.
This looks good.
One question: How is the control displayed by default? As 'Position: Default' or as 'Position: Center Center'.
I believe that the expected behavior is 'Position: Default', and that the default styling should be handled with SCSS.
See the default settings of the Container:
I assume that you are on the right track, because I see similar coding here: https://github.com/elementor/elementor/blob/5777fc0d3955163df07a59f37ca9f844f8866a42/includes/controls/groups/background.php#L142-L141
There was a problem hiding this comment.
@willhowat Thank you for the above feedback.
I would love to hear your feedback on this one.
There was a problem hiding this comment.
@hein-obox this is displayed as in your example 'Default'. We have not set any defaults in the CSS at this time but it's a sensible ask. I'll raise a separate task to get this added
| $available_devices[ $breakpoint_key ] = $breakpoint->get_label(); | ||
| $default_devices[] = $breakpoint_key; | ||
| } | ||
| $configured_breakpoints = $this->get_configured_breakpoints(); |
There was a problem hiding this comment.
@willhowat Can you not use Plugin::$instance->breakpoints->get_active_devices_list()?
…ementor-collaboration into fix/link-in-bio-full-height
…use Plugin::$instance->breakpoints->get_active_devices_list
PR Checklist
PR Type
What kind of change does this PR introduce?
Summary
This PR can be summarized in the following changelog entry:
Description
An explanation of what is done in this PR
Test instructions
This PR can be tested by following these steps:
Quality assurance
Fixes #