Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [i18n] The string "What s New" in Editor Notifications is not displayed translated #25798

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

DAnn2012
Copy link
Contributor

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Summary

This PR can be summarized in the following changelog entry:

  • [i18n] The string "What's New" in Editor Notifications is not displayed translated

Description

An explanation of what is done in this PR

  • Fix for the string "What's New" in Editor Notifications is not displayed translated

Test instructions

This PR can be tested by following these steps:

  • Before - Editor v1 (Language set to Spanish)
    whats-new-v1-1

  • After - Editor v1 (Language set to Spanish)
    whats-new-v1-2

  • Before - Editor v2 (Language set to Spanish)
    whats-new-v2-1

  • After - Editor v2 (Language set to Spanish)
    whats-new-v2-2

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended
  • Docs have been added / updated (for bug fixes / features)

Fixes #

@DAnn2012 DAnn2012 changed the title Fix: [i18n] The string "What's New" in Editor Notifications is not displayed translated Fix: [i18n] The string "What s New" in Editor Notifications is not displayed translated Apr 20, 2024
@DAnn2012
Copy link
Contributor Author

Hi @KingYes ,

please could you kindly take a look at my PR?

Thank you.

@DAnn2012
Copy link
Contributor Author

Hi @louiswol94 ,

please could you kindly take a look at my PR?

Thank you.

@DAnn2012
Copy link
Contributor Author

Hi @louiswol94 ,

please could you kindly take a look at my PR?

Thank you.

@DAnn2012
Copy link
Contributor Author

DAnn2012 commented May 5, 2024

Hi @KingYes ,

please could you kindly take a look at my PR?

Thank you.

@DAnn2012
Copy link
Contributor Author

DAnn2012 commented May 9, 2024

Hi @louiswol94 ,

please could you kindly take a look at my PR?

Thank you.

@DAnn2012
Copy link
Contributor Author

Hi @TzviRabinovitch ,

please could you kindly take a look at my PR?

Thank you.

@DAnn2012
Copy link
Contributor Author

Hi @louiswol94 ,

please could you kindly take a look at my PR?

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants