Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractInstallerView: replace ButtonBox with Boxes #766

Merged
merged 6 commits into from May 24, 2024

Conversation

danirabbit
Copy link
Member

No ButtonBox in Gtk4, so use two boxes

@danirabbit danirabbit requested a review from a team May 7, 2024 18:23
@zeebok
Copy link
Contributor

zeebok commented May 23, 2024

This works but I do notice that some buttons are different sizes:
Before
Screenshot from 2024-05-23 14 16 37

After
Screenshot from 2024-05-23 14 16 21

@danirabbit
Copy link
Member Author

@zeebok okay should be fixed now! I created a button-box css class that includes the minimum width for buttons

Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zeebok zeebok merged commit 8dd639d into master May 24, 2024
3 of 5 checks passed
@zeebok zeebok deleted the danirabbit/installer-actionarea branch May 24, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants