Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MainWindow: Use EventControllerKey #716

Merged
merged 6 commits into from May 14, 2024
Merged

MainWindow: Use EventControllerKey #716

merged 6 commits into from May 14, 2024

Conversation

danirabbit
Copy link
Member

  • Replace key press event with key controller
  • Replace get_style_context with state flags while we're here. The only non-deprecated use of stylecontext is to add a provider to the display

@danirabbit danirabbit requested a review from a team March 8, 2024 00:10
lenemter
lenemter previously requested changes Mar 10, 2024
View reviewed changes
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch blocks Enter key, pressing it no longer logins you in

zeebok
zeebok approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work as intended with I tested in an OS8 VM!

@danirabbit danirabbit merged commit e354389 into master May 14, 2024
4 checks passed
@danirabbit danirabbit deleted the danirabbit/mainwindow-keycontroller branch May 14, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

@lenemter lenemter Awaiting requested review from lenemter

Assignees
No one assigned
Labels
None yet
Projects
GTK4 Porting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danirabbit @zeebok @lenemter