Move EndSessionDialog here #1879
Open
+363
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A modal system dialog currently blocks all shortcuts not sure whether we should (or even can lol) allow things like screenshot, etc.? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the advantage that we can make it modal i.e. we dim everything and prevent all clicks behind it.
It also is wayland compatible. Unfortunately currently the modal part will only work on wayland. It can be made to work on X but that would require some additional effort that - if really wanted - will be left to other PRs. X behavior is therefore unchanged compared to the current end session dialog.
Closes #1877 since the approach taken there had quite a few issues that couldn't be worked around. This approach now uses a clutter actor to block all interaction. This is also more future proof since we can more easily use this for other dialogs that aren't spawned by the daemon, e.g. portal dialogs, etc.