Struts with pantheon protocol #1820
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is quite hacky but this open the way to using the pantheon-desktop-shell protocol.
leolost2605
force-pushed
the
struts-with-pantheon-protocol
branch
from
ccd83f5
to
87407ec
Compare
leolost2605
commented
Jan 15, 2024
| @@ -243,7 +247,55 @@ namespace Gala { | |||
| return; | |||
| } | |||
|
|
|||
| // TODO | |||
| Meta.Side anchor_side = TOP; | |||
| switch (anchor) { | |||
There was a problem hiding this comment.
Not sure whether we can just cast this or whether mutters enum order is likely to change
|
Is there a use case for changing the exclusive are after creating the panel surface? I believe both wingpanel and dock won't change it after set the first time. so making exclusive a parameter on get_panel() should be enough. |
|
I thought about changing dock behavior from auto hide to always show and back 🤷 |
tintou
force-pushed
the
tintou/pantheon-desktop-shell
branch
from
6701c3d
to
f4935ee
Compare
tintou
force-pushed
the
tintou/pantheon-desktop-shell
branch
from
f4935ee
to
96eb93a
Compare
tintou
force-pushed
the
tintou/pantheon-desktop-shell
branch
from
d25ee87
to
bcc2f0e
Compare
tintou
force-pushed
the
tintou/pantheon-desktop-shell
branch
from
bcc2f0e
to
2175085
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
PanelManagerthat handles struts for panel windows and in the future possibly setting the anchor for a panel. The struts are already implemented and working, set_anchor is still waiting for a mutter MR.Regarding the actual API it can be easily changed. Currently it's
make_exclusiveandunmake_exclusiveto closest resemble what's actually happening but it can be changed to something likeset_exclusive (bool exclusive)or KDE's way of setting a flag how the panel should behave.Opinions on this? :)
This PR is based on #1705 (the PR is currently against that branch to reduce the diff)