Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation by keyboard in GridView #585

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Dec 7, 2023

Fixes #584
Fixes #388

  • Correct test for Gdk.SHIFT_MASK in event.state
  • Use properties focused_column, focused_row and current_page_num to simplify and clarify changing page and focused item
  • Consistently use cardinal numbers (starting at 1) for page, column, row variables and map key (unless specifically ending index)
  • Column and row variables consistently refer to the current grid only
  • Restore focus after page change or focus out/in to the previously item
  • Lose some unnecessary code
  • Fix some code style issues

Supercedes #445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant